Fix bug: artifact_registry_repository update always failing

[jcanseco]

This PR fixes a bug where trying to update a google_artifact_registry_repository always failed due to the fact that the resource's Update logic was hitting the wrong API endpoint.

You can reproduce the issue by applying the following configs in succession:

Original:

resource "google_artifact_registry_repository" "my-repo" {
  provider = google-beta

  location = "us-central1"
  repository_id = "my-repository"
  description = "example docker repository"
  format = "DOCKER"
}

New:

resource "google_artifact_registry_repository" "my-repo" {
  provider = google-beta

  location = "us-central1"
  repository_id = "my-repository"
  description = "example docker repository 2"
  format = "DOCKER"
}

Related bugs (with details on impact and priority):

• b/175713067
• Bug: ArtifactRegistryRepository errors with NotReady even after the registry has already been created. k8s-config-connector#348

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

artifactregistry: fixed issue where updating `google_artifact_registry_repository` always failed

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 74 insertions(+))
Terraform Beta: Diff ( 2 files changed, 91 insertions(+), 21 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172001"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 3 files changed, 92 insertions(+), 22 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172002"

[jcanseco]

I'm not sure why the Terraform Beta Diff contains a diff to resource_dataflow_flex_template_job_test.go especially since that diff is not generated when I run the generation locally.

Otherwise, I think this PR should be ready for review. PTAL!

[melinath]

/gcbrun

[melinath]

This LGTM

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 2 files changed, 91 insertions(+), 21 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172040"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccArtifactRegistryRepository_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172128"

[melinath]

Lost track of this over the long weekend - the generate-diffs failure is just a timeout and the run-rake-tests is an unrelated issue that's been fixed on master.

[jcanseco]

Thanks for merging!