Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked preview as Computed: true #8417

Conversation

modular-magician
Copy link
Collaborator

Partially resolved #8251.

I think the issue is that "preview" is optional; if it wasn't provided, it would be tracked as nil by the provider and "false" by the state. When the user goes to make a plan, terraform detects that "preview" will be updated from false -> null, which changes the hash of the object (which looks like a delete/recreate.) Changing to Computed fixes this by setting the provider's value from the API as well as the state.

There is a separate issue where changes are still erroneously detected if a match uses expr instead of config - I'm having some trouble figuring out the best solution in that case but wanted to get the first part out there at least :-)

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed overly-aggressive detection of changes to google_compute_security_policy rules

Derived from GoogleCloudPlatform/magic-modules#4472

@ghost ghost added the size/xs label Feb 8, 2021
@modular-magician modular-magician merged commit 21db975 into hashicorp:master Feb 8, 2021
@ghost
Copy link

ghost commented Mar 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2021
@modular-magician modular-magician deleted the downstream-pr-27749213b4abb96fb5f75d684e96c3425dad6b72 branch November 17, 2024 01:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_security_policy all rules getting recreated
1 participant