Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark replication type computed as it no longer comes back from API #8006

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Mark replication type computed as it no longer comes back from API #8006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/4312.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
sql: fixed a bug in `google_sql_database_instance` that caused a permadiff on `settings.replication_type`
```
2 changes: 1 addition & 1 deletion google/resource_sql_database_instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ settings.backup_configuration.binary_log_enabled are both set to true.`,
Type: schema.TypeString,
Optional: true,
Deprecated: "This property is only applicable to First Generation instances, and First Generation instances are now deprecated.",
Default: "SYNCHRONOUS",
Computed: true,
Description: `This property is only applicable to First Generation instances. First Generation instances are now deprecated, see here for information on how to upgrade to Second Generation instances. Replication type for this instance, can be one of ASYNCHRONOUS or SYNCHRONOUS.`,
},
"user_labels": {
Expand Down