Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark replication type computed as it no longer comes back from API #8006

Conversation

modular-magician
Copy link
Collaborator

Fixes: #7990

This field no longer appears in the API response. This combined with the Default value in Terraform causes Terraform to permadiff on the field. Workaround until an updated provider version is available with

lifecycle {
  ignore_changes = [settings.0.replication_type]
}

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: fixed a bug in `google_sql_database_instance` that caused a permadiff on `settings.replication_type`

Derived from GoogleCloudPlatform/magic-modules#4312

@ghost ghost added size/xs labels Dec 12, 2020
@modular-magician modular-magician merged commit de9f852 into hashicorp:master Dec 12, 2020
slevenick pushed a commit that referenced this pull request Dec 12, 2020
@tarrencev
Copy link

Could you please release with this change 👍

@slevenick
Copy link
Collaborator

Could you please release with this change 👍

Yup it's released in 3.51.0. We are in the process of updating the changelog, but it should be released as of now

@tarrencev
Copy link

thank you!

yegle added a commit to yegle/exposure-notifications-server that referenced this pull request Dec 17, 2020
yegle added a commit to yegle/exposure-notifications-verification-server that referenced this pull request Dec 17, 2020
google-oss-robot pushed a commit to google/exposure-notifications-server that referenced this pull request Dec 17, 2020
google-oss-robot pushed a commit to google/exposure-notifications-verification-server that referenced this pull request Dec 17, 2020
@ghost
Copy link

ghost commented Jan 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 11, 2021
@modular-magician modular-magician deleted the downstream-pr-10a2e60fbb0a1c4e34e4fb6dd93b8790606c57f7 branch November 17, 2024 02:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_sql_database_instance.settings.0.replication_type diff on "SYNCHRONOUS" value
3 participants