Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding data source for identity pool provider #7733

Conversation

modular-magician
Copy link
Collaborator

final part of #7455
this add a datasource for google_iam_workload_identity_pool_provider similar to the datasource google_iam_workload_identity_pool that was added in #4134 This is the data source version of the resource that is added in #4129

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know). warning running the new data source test locally fails with a 404 error. I had the same issue with the previous PR Remove quotes from boolean #4134 but those testa apparantly run okay at your end. I never figured out what is wrong at my end.
  • Read the Release Notes Guide before writing my release note below.

Fixes #7455

`google_iam_workload_identity_pool_provider`

I'll keep this in draft until #4129 is merged as this branch also includes those changes. The diff will clean up to only the data source changes once that PR is merged

Derived from GoogleCloudPlatform/magic-modules#4181

Co-authored-by: Scott Suarez <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/s label Nov 6, 2020
@modular-magician modular-magician merged commit 016b6d4 into hashicorp:master Nov 6, 2020
@ghost
Copy link

ghost commented Dec 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@modular-magician modular-magician deleted the downstream-pr-7c844755883fcf1de9ed85f7424f8102a522237a branch November 16, 2024 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: IAM Workload Identity Federation resources
1 participant