Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding data source for identity pool provider #4181

Conversation

wvanderdeijl
Copy link
Contributor

final part of hashicorp/terraform-provider-google#7455
this add a datasource for google_iam_workload_identity_pool_provider similar to the datasource google_iam_workload_identity_pool that was added in #4134 This is the data source version of the resource that is added in #4129

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know). warning running the new data source test locally fails with a 404 error. I had the same issue with the previous PR adding data source for identity pool #4134 but those testa apparantly run okay at your end. I never figured out what is wrong at my end.
  • Read the Release Notes Guide before writing my release note below.

Fixes hashicorp/terraform-provider-google#7455

`google_iam_workload_identity_pool_provider`

I'll keep this in draft until #4129 is merged as this branch also includes those changes. The diff will clean up to only the data source changes once that PR is merged

@google-cla google-cla bot added the cla: yes label Nov 2, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 406 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 17 files changed, 1934 insertions(+), 30 deletions(-))
TF OiCS: Diff ( 16 files changed, 483 insertions(+))

@rileykarson
Copy link
Member

@wvanderdeijl: let me know if this is ready to review, or if you need to do anything else before I do!

@wvanderdeijl wvanderdeijl marked this pull request as ready for review November 2, 2020 18:14
@wvanderdeijl
Copy link
Contributor Author

@rileykarson I have merged master into this so the PR now only contains the actual changes for the new datasource.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 47 insertions(+))
Terraform Beta: Diff ( 6 files changed, 137 insertions(+), 1 deletion(-))

@wvanderdeijl
Copy link
Contributor Author

@rileykarson is this one good to go, or do you want me to change some things?

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry about the delay! I've been fairly busy, so it's taking me longer than usual to make code review passes.

@rileykarson
Copy link
Member

Gonna run the VCR tests with /gcbrun before merging, I don't expect it to fail though.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156220"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 47 insertions(+))
Terraform Beta: Diff ( 6 files changed, 137 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceSpannerInstance_basic|TestAccBigqueryDataTransferConfig|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_vpcConnector|TestAccGameServicesGameServerConfig_gameServiceConfigBasicExample|TestAccGameServicesGameServerDeploymentRollout_gameServiceDeploymentRolloutBasicExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156235"

}

resource "google_iam_workload_identity_pool_provider" "bar" {
workload_identity_pool_id = "pool-%{random_suffix}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to interpolate this value off the google_iam_workload_identity_pool above, otherwise this gets created at the same time as it's parent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing! There was a test failure because the dependency graph wasn't complete.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 47 insertions(+))
Terraform Beta: Diff ( 6 files changed, 137 insertions(+), 1 deletion(-))

@rileykarson
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156244"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 47 insertions(+))
Terraform Beta: Diff ( 6 files changed, 137 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceSpannerInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccComposerEnvironment_withUpdateOnCreate|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreInstance_update|TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesPackagesExample|TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156331"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: IAM Workload Identity Federation resources
3 participants