Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send empty privateVisibilityConfig network array #7022

Conversation

modular-magician
Copy link
Collaborator

fixes #6973

The api only removes the privateVisibilityConfig block when sending an empty networks array like so:

  "privateVisibilityConfig": {
    "networks": []
  }

Added a custom expander to do this. Using a custom expander on the parent field removed the expanders for the subfields, so I included the subfield expanders in the template. This makes the custom expander looks excessive, but generates small downstream diffs.

Release Note Template for Downstream PRs (will be copied)

dns: fixed an issue where `google_dns_managed_zone` would not remove `private_visibility_config` on updates

Derived from GoogleCloudPlatform/magic-modules#3865

@ghost ghost added size/xs labels Aug 13, 2020
@modular-magician modular-magician merged commit 9c9430f into hashicorp:master Aug 13, 2020
@ghost
Copy link

ghost commented Sep 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 13, 2020
@modular-magician modular-magician deleted the downstream-pr-0b0c6936de2b8c301b40463a361cde8c8700e2a3 branch November 17, 2024 00:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_dns_managed_zone : in-place update for private_visibility_config cannot remove network
1 participant