google_dns_managed_zone : in-place update for private_visibility_config cannot remove network

[imrannayer]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

v0.12.21

Affected Resource(s)

• google_dns_managed_zone

Terraform Configuration Files

resource "google_dns_managed_zone" "sd-zone" {
  provider = google-beta

  name        = "peering-zone"
  dns_name    = "services.example.com."
  description = "Example private DNS Service Directory zone"

  visibility = "private"
  private_visibility_config {
    networks {
      network_url = google_compute_network.network-source.id
    }
  }
  service_directory_config {
    namespace {
      namespace_url = google_service_directory_namespace.example.id
    }
  }
}

Debug Output

Panic Output

Expected Behavior

If private_visibility_config is removed plan shows it will remove the block but it is not able to remove.

Actual Behavior

private_visibility_config will still be there.

Steps to Reproduce

1. Create google_dns_managed_zone with private_visibility_config block pointing to a network
2. Remove private_visibility_config from code and run the code again
3. plan will show it will remove network visibility.
4. Code executes fine but network visibility stays in place.

Important Factoids

References

• #0000

[edwardmedia]

private_visibility_config block is missing in the PATCH payload

2020-08-07T14:59:24.375Z [DEBUG] plugin.terraform-provider-google_v3.33.0_x5: PATCH /dns/v1/projects/myproject/managedZones/issue6973private-zone?alt=json HTTP/1.1
2020-08-07T14:59:24.375Z [DEBUG] plugin.terraform-provider-google_v3.33.0_x5: 
2020-08-07T14:59:24.375Z [DEBUG] plugin.terraform-provider-google_v3.33.0_x5: {
2020-08-07T14:59:24.375Z [DEBUG] plugin.terraform-provider-google_v3.33.0_x5:  "description": "Example private DNS zone",
2020-08-07T14:59:24.375Z [DEBUG] plugin.terraform-provider-google_v3.33.0_x5:  "labels": {
2020-08-07T14:59:24.375Z [DEBUG] plugin.terraform-provider-google_v3.33.0_x5:   "foo": "bar"
2020-08-07T14:59:24.375Z [DEBUG] plugin.terraform-provider-google_v3.33.0_x5:  }
2020-08-07T14:59:24.375Z [DEBUG] plugin.terraform-provider-google_v3.33.0_x5: }
2020-08-07T14:59:24.375Z [DEBUG] plugin.terraform-provider-google_v3.33.0_x5: 

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!