Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation of metric_sum_in_range.max #6929

Closed
wants to merge 1 commit into from

Conversation

tmarszal
Copy link

@tmarszal tmarszal commented Aug 4, 2020

Fixed validation of windows_based_sli.metric_sum_in_range.range.max. It was always required because of that.

Fixed validation of windows_based_sli.metric_sum_in_range.range.max. It was always required because of that.
@ghost ghost added the size/xs label Aug 4, 2020
@ghost ghost requested a review from c2thorn August 4, 2020 08:17
@tmarszal tmarszal changed the title Update resource_monitoring_slo.go Fix validation of metric_sum_in_range.max Aug 4, 2020
@c2thorn
Copy link
Collaborator

c2thorn commented Aug 4, 2020

Hi @tmarszal, nice catch! Do you mind making this change upstream in our Magic Modules repo? This way the change can distribute to both google and google-beta. You can find the necessary code here:
https://github.com/GoogleCloudPlatform/magic-modules/blob/master/products/monitoring/api.yaml#L1565

@tmarszal
Copy link
Author

tmarszal commented Aug 5, 2020

Created PR: GoogleCloudPlatform/magic-modules#3826
Thanks for pointing me to the right direction!

@tmarszal
Copy link
Author

tmarszal commented Aug 5, 2020

Should I close this PR?

@c2thorn
Copy link
Collaborator

c2thorn commented Aug 5, 2020

I got it!

@c2thorn c2thorn closed this Aug 5, 2020
@ghost
Copy link

ghost commented Sep 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants