Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed validation of service_level_indicator.0.windows_based_sli.0.metric_sum_in_range.0.range.0.max #3826

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

tmarszal
Copy link
Contributor

@tmarszal tmarszal commented Aug 5, 2020

Fixed validation of service_level_indicator.0.windows_based_sli.0.metric_sum_in_range.0.range.0.max

Release Note Template for Downstream PRs (will be copied)

monitoring: fixed validation rules for `google_monitoring_slo` `windows_based_sli.metric_sum_in_range.max` field

Fixed validation of service_level_indicator.0.windows_based_sli.0.metric_sum_in_range.0.range.0.max
@google-cla
Copy link

google-cla bot commented Aug 5, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 5, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@tmarszal
Copy link
Contributor Author

tmarszal commented Aug 5, 2020

@googlebot I signed it!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@c2thorn c2thorn requested review from c2thorn and removed request for nat-henderson August 5, 2020 20:20
@c2thorn
Copy link
Member

c2thorn commented Aug 6, 2020

Hey @tmarszal , thanks for the contribution! I'm having a bit of trouble with our cloud build trigger, do you mind amending/repushing your commit to set the trigger again?

@tmarszal
Copy link
Contributor Author

tmarszal commented Aug 7, 2020

Done 🤞

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@c2thorn
Copy link
Member

c2thorn commented Aug 7, 2020

Perfect, thanks @tmarszal !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants