Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql_instance): add support for point_in_time_recovery #6715

Merged
merged 5 commits into from
Aug 5, 2020
Merged

feat(sql_instance): add support for point_in_time_recovery #6715

merged 5 commits into from
Aug 5, 2020

Conversation

ykyr
Copy link
Contributor

@ykyr ykyr commented Jun 29, 2020

This allows enabling Point in time recovery feature for Cloud SQL.

@ghost ghost added the size/xs label Jun 29, 2020
@ghost ghost requested review from danawillow June 29, 2020 08:54
@ghost ghost added the documentation label Jun 29, 2020
@ykyr
Copy link
Contributor Author

ykyr commented Jun 29, 2020

Not sure why CI fails. I hope it's okay to have PR in this repo, and it will be upstreamed to MM 🤞 🙂
Community contributors can contribute directly to Magic Modules, or they can contribute directly to this repo

danawillow
danawillow suggested changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failure looks unrelated. This PR looks good, except for one quick change. Can you also add a new test or update an existing test to use the new field? I'll let you use your judgment on which one makes more sense.

google/resource_sql_database_instance.go Outdated Show resolved Hide resolved
@ghost ghost added size/m and removed size/xs labels Jun 30, 2020
@gplasky
Copy link

gplasky commented Jul 17, 2020

I was going to pick up #6774 until I found this; thanks for making it happen!

danawillow
danawillow reviewed Jul 30, 2020
View reviewed changes
google/resource_sql_database_instance_test.go Outdated Show resolved Hide resolved
google/resource_sql_database_instance_test.go Outdated Show resolved Hide resolved
google/resource_sql_database_instance_test.go Outdated Show resolved Hide resolved
google/resource_sql_database_instance_test.go Outdated Show resolved Hide resolved
google/resource_sql_database_instance_test.go Outdated Show resolved Hide resolved
@doriandekoning doriandekoning mentioned this pull request Aug 2, 2020
Closed
@ykyr ykyr requested a review from danawillow August 4, 2020 06:44
@danawillow danawillow mentioned this pull request Aug 4, 2020
Merged
danawillow
danawillow approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Opened GoogleCloudPlatform/magic-modules#3819 to upstream this to magic modules.

@danawillow danawillow merged commit 1105e1a into hashicorp:master Aug 5, 2020
This was referenced Aug 5, 2020
Merged
Merged
@ghost
Copy link

ghost commented Sep 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
documentation size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ykyr @gplasky @danawillow