Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CloudSQL Point-In-Time-Recovery (PostgreSQL) #6774

Closed
mr-andyd opened this issue Jul 9, 2020 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#3819, #6944 or hashicorp/terraform-provider-google-beta#2338

Comments

@mr-andyd
Copy link

mr-andyd commented Jul 9, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Google now officially supports point-in-time-recovery for Postgres CloudSQL as of yesterday. This has been a lacking feature on GCP's part for quite some time. It would be nice to support this functionality within the settings.backup_configuration subblock.

New or Affected Resource(s)

  • google_sql_database_instance

Potential Terraform Configuration

resource "google_sql_database_instance" "instance" {
  provider = google-beta

  name   = "private-instance-${random_id.db_name_suffix.hex}"
  region = "us-central1"

  settings {
    ...
    backup_configuration {
      enabled = var.db_settings.backups_enabled
      start_time = var.db_settings.start_time
      location = "Asia"
      pitr_enabled = true
    }
    ...
  }
}

References

@gplasky
Copy link

gplasky commented Jul 17, 2020

@ykyr since you're already working on the feature.

@ghost
Copy link

ghost commented Sep 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 5, 2020
@github-actions github-actions bot added forward/review In review; remove label to forward service/sqladmin-cp labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.