Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "inbound_services" to google_app_engine_standard_app_version #6387

Closed
wants to merge 1 commit into from
Closed

Add "inbound_services" to google_app_engine_standard_app_version #6387

wants to merge 1 commit into from

Conversation

pmarschik
Copy link

No description provided.

@ghost ghost added the size/xs label May 15, 2020
@ghost ghost requested a review from slevenick May 15, 2020 11:31
@slevenick
Copy link
Collaborator

Hey @pmarschik thanks for the contribution!

Unfortunately merging this change would cause it to be overwritten by our code generator, as this entire file is generated by Magic Modules.

If you would like to contribute to that repository to get this generated that would be great!

Basically it would just require adding this field to the API description of the StandardAppVersion resource, and then it should add it to the resource and generate docs.

See: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/products/appengine/api.yaml#L215

@pmarschik pmarschik mentioned this pull request May 19, 2020
Merged
@pmarschik
Copy link
Author

Hey @slevenick thanks for getting back so fast!

I've ported the change in GoogleCloudPlatform/magic-modules#3537 (still need our legal to OK my CLA)

This was referenced Jun 2, 2020
Merged
Merged
Merged
Merged
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Aug 15, 2022
@modular-magician
remove forceNew on display_name (hashicorp#6387)
9f04634 
Co-authored-by: Edward Sun <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit that referenced this pull request Aug 15, 2022
@modular-magician
remove forceNew on display_name (#6387) (#12311)
e31ee86 
Co-authored-by: Edward Sun <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Signed-off-by: Modular Magician <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
@rileykarson
Copy link
Collaborator

Superseded by GoogleCloudPlatform/magic-modules#3537

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slevenick slevenick Awaiting requested review from slevenick

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmarschik @slevenick @rileykarson