Add "inbound_services" to google_app_engine_standard_app_version

[pmarschik]

Release Note Template for Downstream PRs (will be copied)

appengine: add `inbound_services` to `StandardAppVersion` resource

References

• Add "inbound_services" to google_app_engine_standard_app_version hashicorp/terraform-provider-google#6387 /cc @slevenick

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@danawillow, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 35 insertions(+))
Terraform Beta: Diff ( 2 files changed, 35 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
Inspec: Diff ( 4 files changed, 7 insertions(+))

[danawillow]

Holding off on the review until the CLA is signed.

[pmarschik]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[danawillow]

Can you add a test (or modify an existing one) that sets this field? Since it's updatable, TestAccAppEngineStandardAppVersion_update is probably a good place for it.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 39 insertions(+))
Terraform Beta: Diff ( 3 files changed, 39 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
Inspec: Diff ( 4 files changed, 7 insertions(+))

[danawillow]

I'd recommend making this a set instead (is_set: true in terraform.yaml) because the order these are specified in shouldn't matter.

[danawillow]

Can we test having multiple values in this? (not in a separate test, just put like 3ish values in this array)

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@SirGitsalot, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 51 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 51 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 12 insertions(+))
Inspec: Diff ( 4 files changed, 7 insertions(+))

[danawillow]

Looks good, thanks @pmarschik!

Converting from a list --> set on an existing resource has the potential to be a breaking change, since people could have been indexing into an array during interpolation. However, I think in this case that since it's a simple list of strings, it should be pretty safe so I'm fine with the change.