Initial retry transport #5902
Merged
Initial retry transport #5902
+491
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* retry transport * lint * remove import, comments * Rename copyRequest, change comments, remove redundant line * refactor test * clarifications, defers * lint/fmt Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
modular-magician
deleted the
downstream-pr-58bcc3e2c33a629b702714a698ff097373c523f6
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this stage, this only adds a retry transport but doesn't change the retry loops outside of the transport (i.e. those wrapping httpClient.Do(req) in
sendRequest()or golangClient.Request().Do()).I think removal of retry-loop work needs to be done more carefully, in case we end up changing the behavior, but we should hopefully move to having sendRequest/resource.Retry only send API/resource specific errorRetryPredicates.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3196