Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential perma-diff with metric_descriptor.labels in logging_metric #5732

Closed
wants to merge 1 commit into from
Closed

Fix potential perma-diff with metric_descriptor.labels in logging_metric #5732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/resource_logging_metric.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ example, the appengine.googleapis.com/http/server/response_latencies metric type
for the HTTP response code, response_code, so you can look at latencies for successful responses
or just for responses that failed.`,
Elem: loggingMetricMetricDescriptorLabelsSchema(),
// Default schema.HashSchema is used.
Set: schema.HashResource(loggingMetricMetricDescriptorLabelsSchema()),
},
"unit": {
Type: schema.TypeString,
Expand Down