Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential perma-diff with metric_descriptor.labels in logging_metric #5732

Closed
wants to merge 1 commit into from
Closed

Fix potential perma-diff with metric_descriptor.labels in logging_metric #5732

wants to merge 1 commit into from

Conversation

xanonid
Copy link

@xanonid xanonid commented Feb 21, 2020

Fixes: #4141

@xanonid
Fix potential perma-diff with metric_descriptor.labels in google_logg…
268d4ce 
…ing_metric

Depending on the ordering of the labels, there could be a perma-diff.
This fixes this.
@ghost ghost added the size/xs label Feb 21, 2020
@ghost ghost requested review from chrisst and nat-henderson February 21, 2020 09:02
@nat-henderson nat-henderson requested review from emilymye and removed request for nat-henderson and chrisst February 21, 2020 19:03
@emilymye
Copy link
Contributor

emilymye commented Feb 21, 2020 •
edited
Loading

Hi @xanonid - do you have an example of config that recreates this issue? I'm having trouble reproducing, and the default HashSchema calls out to HashResource(schema.Elem) for sets and lists so it would be very strange if this was a fix.

@xanonid
Copy link
Author

xanonid commented Feb 22, 2020

@emilymye
I close this PR as the issue seems to be really already fixed - sorry. I had unfortunately a version constraints to an outdated 2.x provider version which had still the issue.

@xanonid xanonid closed this Feb 22, 2020
@ghost
Copy link

ghost commented Mar 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emilymye emilymye Awaiting requested review from emilymye

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_logging_metric needs metric_descriptor.labels in a specific order or results in permadiff
2 participants
@xanonid @emilymye