Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry on resource read for dns.ResourceRecordSetsListResponse #4769

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

bjorand
Copy link
Contributor

@bjorand bjorand commented Oct 29, 2019

Hello,

I have 600 google_dns_record_set resources and I'm unable to plan or apply as GCP returns a lot of 503 errors (even with --parallelism=1):

Error reading DNS Record Set "xxx.": googleapi: Error 503: Backend Error, backendError

This PR implements retry and fixes this problem.

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although it'll need to be upstreamed into magic modules. Would you like to do that, or should I take it?

@danawillow
Copy link
Contributor

@ndmckinley can you upstream this if it's still useful?

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants