Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry on resource read for dns.ResourceRecordSetsListResponse #4768

Closed

Conversation

bjorand
Copy link
Contributor

@bjorand bjorand commented Oct 29, 2019

Hello,

I have 600 google_dns_record_set resources and I'm unable to plan or apply as GCP returns a lot of 503 errors (even with --parallelism=1):

Error reading DNS Record Set "xxx.": googleapi: Error 503: Backend Error, backendError

This PR implements retry and fixes this problem.

@ghost ghost added the size/xs label Oct 29, 2019
@ghost ghost requested a review from nat-henderson October 29, 2019 10:13
@bjorand bjorand closed this Oct 29, 2019
@bjorand bjorand deleted the fix_503_dns_google_record_set branch October 29, 2019 10:39
@bjorand bjorand restored the fix_503_dns_google_record_set branch October 29, 2019 10:39
@bjorand bjorand deleted the fix_503_dns_google_record_set branch October 29, 2019 12:49
@nat-henderson
Copy link
Contributor

Hey there!

I'd be happy to review this PR. Should I wait for you to reopen it or resubmit it?

@bjorand
Copy link
Contributor Author

bjorand commented Oct 29, 2019

Hi @ndmckinley, yes sure, you can check #4769 👍

@ghost
Copy link

ghost commented Nov 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants