[Issue #3999] add graceful decommissioning timeout to dataproc resource #4122
Conversation
There was a problem hiding this comment.
Hi @jaketf! Making the PR here is fine; I can upstream it to MM once it's ready. If you did want to add it in MM, the file is at https://github.com/GoogleCloudPlatform/magic-modules/blob/master/third_party/terraform/resources/resource_dataproc_cluster.go.erb.
I'd also appreciate a test in resource_dataproc_cluster_test.go, and documentation in dataproc_cluster.html.markdown. For the test, since this is a property specific to the update call and not something that can be read back from the resource, I don't have a great sense of what the test would look like, but maybe you can think of something that would fail without it sent. If not, I still think having a test where it exists so we know we called the API correctly would still be useful.
There's some information at https://github.com/terraform-providers/terraform-provider-google/blob/master/.github/CONTRIBUTING.md#tests on how to run tests. Let me know if you have any questions!
| @@ -717,6 +717,7 @@ func resourceDataprocClusterUpdate(d *schema.ResourceData, meta interface{}) err | |||
| region := d.Get("region").(string) | |||
| clusterName := d.Get("name").(string) | |||
| timeoutInMinutes := int(d.Timeout(schema.TimeoutUpdate).Minutes()) | |||
| gracefulDecommissionTimeout := d.Get("gracefulDecommisionTimeout").(string) | |||
There was a problem hiding this comment.
In order to read this property, it needs to be in the schema defined at the top of the file
|
Oh also, fun github fact, if you say "fixes #x" in your PR description or commit message, it'll automatically close the linked issue once the PR is merged. |
|
Hey again @jaketf, I just noticed you already made the PR in magic modules too (GoogleCloudPlatform/magic-modules#2110). I'm going to close this out so that there's only one PR for the feature, but my comment above still applies. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This PR is to address #3999.
This is my first PR and I expect that I'm missing test cases etc.
Please advise if I should make this PR upstream in magic modules (I could not find a dataproc product there).