Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource_dataproc_cluster.go.erb #2110

Conversation

jaketf
Copy link

@jaketf jaketf commented Jul 26, 2019

This PR is to address Issue #3999 for terraform-google-provider.

This is my first PR and I don't really write golang regularly and am confused how to test this go code or if that is something MM will take care of for me.
I'm trying to get some traction on #3999
Please advise on how to make this a more complete PR.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@slevenick
Copy link
Contributor

Hey @jaketf, thanks for the contribution!

Unfortunately it looks like this change will be a bit complicated. It looks like the gracefulDecommissionTimeout field is set using a query parameter on the PATCH request: https://cloud.google.com/dataproc/docs/reference/rest/v1/projects.regions.clusters/patch

To get this to work from terraform would require adding an optional field for gracefulDecommissionTimeout in the resource's schema (to allow a user to specify it via terraform config) and then adding some custom code that adds this parameter (if it exists) to the URL used by the patch request.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of f545b5c.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1001
depends: hashicorp/terraform-provider-google#4177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants