Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timePartitioning.requirePartitionFilter field to google_bigquery_table resource #2288

Closed
wants to merge 7 commits into from
Closed

Add timePartitioning.requirePartitionFilter field to google_bigquery_table resource #2288

wants to merge 7 commits into from

Conversation

amatellanes
Copy link
Contributor

tpoindessous and others added 2 commits October 17, 2018 14:35
@tpoindessous @rileykarson
Create a link to storage_bucket_acl documentation (hashicorp#2275)
ddd9e01 
Create a link to storage_bucket_acl ressource documentation page.

It's easier than scrolling and scrolling or copy text and search it on the page.

Thank you !
Add timePartitioning.requirePartitionFilter field to google_bigquery_…
86133b3 
…table resource
@ghost ghost added the size/xs label Oct 19, 2018
@rileykarson rileykarson self-requested a review November 13, 2018 00:08
@rileykarson rileykarson self-assigned this Nov 13, 2018
@rileykarson rileykarson changed the base branch from master to 2.0.0 November 13, 2018 16:09
@rileykarson rileykarson mentioned this pull request Nov 13, 2018
Merged
rileykarson
rileykarson requested changes Nov 13, 2018
View reviewed changes
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I just have a few small comments, so I decided to play with the new GitHub suggestions feature. Feel free to take those, or to edit by hand.

If you're interested, you could also upstream these changes to Magic Modules, in the third_party/terraform directory. It's the canonical home of this provider (the google provider) and the google-beta provider, and changes made there will fan out across both provider's repos. If not, I'll gladly apply them upstream myself!

google/resource_bigquery_table_test.go Outdated Show resolved Hide resolved
google/resource_bigquery_table_test.go Outdated Show resolved Hide resolved
website/docs/r/bigquery_table.html.markdown Outdated Show resolved Hide resolved
google/resource_bigquery_table.go Outdated Show resolved Hide resolved
rileykarson and others added 4 commits November 14, 2018 10:08
@rileykarson @amatellanes
Remove empty line
48033fa 
Co-Authored-By: amatellanes <[email protected]>
@rileykarson @amatellanes
Fix indentation
ffb5547 
Co-Authored-By: amatellanes <[email protected]>
@rileykarson @amatellanes
Fix typo
6e4980f 
Co-Authored-By: amatellanes <[email protected]>
@rileykarson @amatellanes
Remove useless comment
80533f7 
Co-Authored-By: amatellanes <[email protected]>
@prodriguezdefino
Copy link

hey guys do we have any news on this PR?

@rileykarson
Copy link
Collaborator

Ah, looks like I didn't get a notification when those changes were applied. I'll get this in for 2.0.0.

@ghost ghost added the documentation label Dec 18, 2018
@rileykarson rileykarson mentioned this pull request Jan 7, 2019
Merged
@rileykarson
Copy link
Collaborator

Ah, this slipped my mind for a bit- because of the base branch changes and what that's done to history, I'm going to supersede this PR with GoogleCloudPlatform/magic-modules#1172.

@rileykarson rileykarson closed this Jan 7, 2019
@ghost
Copy link

ghost commented Feb 7, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rileykarson rileykarson rileykarson requested changes

Assignees

@rileykarson rileykarson

Labels
documentation size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amatellanes @prodriguezdefino @rileykarson @tpoindessous