Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a link to storage_bucket_acl documentation #2275

Merged
merged 2 commits into from
Oct 17, 2018

Conversation

tpoindessous
Copy link
Contributor

Create a link to storage_bucket_acl ressource documentation page.

It's easier than scrolling and scrolling or copy text and search it on the page.

Thank you !

Create a link to storage_bucket_acl ressource documentation page.
@ghost ghost added the size/xs label Oct 17, 2018
@tpoindessous
Copy link
Contributor Author

Tell me if making link to other pages of ressources is allowed and is wanted by the project.

I find it very useful and I'm very ready to submit another PR, way larger, with a lot of links.

Thanks !

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me! I have a question/suggestion about the link shape if you don't mind.

website/docs/r/storage_bucket.html.markdown Outdated Show resolved Hide resolved
Link must be absolute and not relative
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change!

@rileykarson rileykarson merged commit ddd9e01 into hashicorp:master Oct 17, 2018
@tpoindessous tpoindessous deleted the patch-2 branch October 18, 2018 06:55
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
Create a link to storage_bucket_acl ressource documentation page.

It's easier than scrolling and scrolling or copy text and search it on the page.

Thank you !
@ghost
Copy link

ghost commented Nov 17, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants