Make schema for args of Cloud Build steps a list #2101
Conversation
Because strings.Split cannot handle string arguments including space. For example, "git commit -m \"New Commit\"" cf. https://godoc.org/google.golang.org/api/cloudbuild/v1#BuildStep
|
Hi! Thanks for the PR. I see what you're going for here, but sadly, we're unable to merge this change until 2.0.0, as it's a breaking change. If you're comfortable waiting for that, that's awesome. If not, an interim solution may be to look into a more flexible parsing approach for the string that's able to take quotes into consideration. |
|
Hi @paddycarver ! Thank you for your reply! 😄 I understood. I would like to think about another parsing approach. I have a branch to change another point of cloudbuild trigger, so I'll make a PR of this problem after that. |
Right now, cloudbuild trigger's args field expects a string, then splits that string on spaces to get the list the API wants. This doesn't do proper quote escaping, however, and creates problems, which led to hashicorp/terraform-provider-google#2101. This change turns it into a list instead of a string, so the user can take care of the parsing and escaping themselves. This is a breaking change, and should only go out with 2.0.0. We talked about the transition paths available to us, and this seemed the most reasonable.
|
Superseded by GoogleCloudPlatform/magic-modules#1145 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Because strings.Split cannot handle string arguments including space.
For example, "git commit -m "New Commit""
Thanks.
cf. https://godoc.org/google.golang.org/api/cloudbuild/v1#BuildStep