Autogenerate Cloud Build Trigger in Terraform #1145
Conversation
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit ac2b08f) have been included in your existing downstream PRs. |
| @@ -0,0 +1,14 @@ | |||
| // `name` is autogenerated from the api so needs to be set post-create | |||
There was a problem hiding this comment.
It seems like we'll need one of these for each resource with an id that's set during create - I think there's a lot of those. Do you think it's worth it to make this a magic-modules-level field? set_during_create: true or something?
There was a problem hiding this comment.
We have set_computed_name.erb for the common name case (similar to update mask) but this one is different since we're recording the id, and this is one of the only non-numeric id values. I don't think this is worth templating yet since this particular pattern is still isolated. If we get to 3 that are nearly identical imo that's when it's worth it.
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit c055029) have been included in your existing downstream PRs. |
|
Waiting on @paddycarver's response about the shape change to merge. Edit: We're making the hard cut with this PR since there isn't a great way to make a gradual deprecation here |
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
cloudbuild-trigger
branch
from
5ef766a to
c2160a2
Compare
Every top level field + every field under
buildthat Terraform supports is added- the docs are hard to parse for the other fields so I split the rest out of this PR since adding them will be easy enough in a followup & it means it will be 2 individually smaller PRs.idis a server-provided identifier that isn't a unique number in this resource; instead, it's a string (GUID I think?) and works like thenameof aself_linkstyle resource. MM took some fiddling to make it work - probably worth considering this resource in https://github.com/GoogleCloudPlatform/magic-modules/issues/937This also makes the breaking change from hashicorp/terraform-provider-google#2101
Part of https://github.com/GoogleCloudPlatform/magic-modules/issues/1134
[all]
[terraform]
Autogenerate google_cloudbuild_trigger
[terraform-beta]
[ansible]
[inspec]