Refactor muxing 2 : Remove unused code, resulting from #11903 #20433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp#11578) [upstream:665013b5123eb77dc53a70c23045ac8b4a206caa] Signed-off-by: Modular Magician <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to GoogleCloudPlatform/magic-modules#11903.
Most commits in this PR are in that PR, and will 'disappear' once this PR is unblocked and ready for review.This PR has been rebased to address this!This PR deletes all the parallel implementations of provider configuration logic. The PR GoogleCloudPlatform/magic-modules#11903 stops the provider using this duplicated logic, and this PR removes that redundant code.
In future the team may want to revisit this deleted code to inform work to pulls out the SDKv2 from the codebase completely and the provider becomes 100% plugin-framework. As that is a long way in the future I think it's best to delete this code now for clarity. It will still be in version control for reference in the future.
When looking at the deleted code be wary of:
ephemeral: addgoogle_service_account_id_tokenGoogleCloudPlatform/magic-modules#12141 (comment)Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11578