-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor muxing 2 : Remove unused code, resulting from #11903 #11578
Refactor muxing 2 : Remove unused code, resulting from #11903 #11578
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
43bd0a6
to
47bb9bc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
5e8070f
to
47bb9bc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
47bb9bc
to
98bba88
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
98bba88
to
265c2f0
Compare
Rebased to pull in Go rewrite |
265c2f0
to
dee2be2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…ific provider configuration code.
dee2be2
to
2f8d100
Compare
Tests analyticsTotal tests: 4306 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed things deleted were only used by what was also being deleted. LGTM
Thanks, I'll go ahead and merge as I don't think there's a need for multiple approvals here vs the first PR |
Follow up to #11903.
Most commits in this PR are in that PR, and will 'disappear' once this PR is unblocked and ready for review.This PR has been rebased to address this!This PR deletes all the parallel implementations of provider configuration logic. The PR #11903 stops the provider using this duplicated logic, and this PR removes that redundant code.
In future the team may want to revisit this deleted code to inform work to pulls out the SDKv2 from the codebase completely and the provider becomes 100% plugin-framework. As that is a long way in the future I think it's best to delete this code now for clarity. It will still be in version control for reference in the future.
When looking at the deleted code be wary of:
ephemeral
: addgoogle_service_account_id_token
#12141 (comment)Release Note Template for Downstream PRs (will be copied)