Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute: forced recreation of google_compute_security_policy on type updates #20316

Conversation

modular-magician
Copy link
Collaborator

Updating the type of google_compute_security_policy (e.g., from CLOUD_ARMOR to CLOUD_ARMOR_EDGE) requires the resource to be recreated.

Fixes #20071

Without the change (and without the plancheck), verified that this test fails.

    resource_compute_security_policy_test.go:43: Step 3/4 error: Check failed: Check 1/1 error: google_compute_security_policy.policy: Attribute 'type' expected "CLOUD_ARMOR_EDGE", got "CLOUD_ARMOR"
--- FAIL: TestAccComputeSecurityPolicy_basicUpdate (41.37s)

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fixed permadiff on attempted `type` field updates in `google_computer_security_policy`, updating this field will now force recreation of the resource

Derived from GoogleCloudPlatform/magic-modules#12233

…pe` updates (hashicorp#12233)

[upstream:acda2f0f71f92d1b4ff964acffc4de6f88cd585a]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 4948856 into hashicorp:main Nov 12, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-acda2f0f71f92d1b4ff964acffc4de6f88cd585a branch November 17, 2024 00:56
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chhanging type in google_compute_security_policy does not cause the resource to be recreated
1 participant