compute: forced recreation of google_compute_security_policy on type updates

[wyardley]

Updating the type of google_compute_security_policy (e.g., from CLOUD_ARMOR to CLOUD_ARMOR_EDGE) requires the resource to be recreated.

Fixes hashicorp/terraform-provider-google#20071

Without the change (and without the plancheck), verified that this test fails.

    resource_compute_security_policy_test.go:43: Step 3/4 error: Check failed: Check 1/1 error: google_compute_security_policy.policy: Attribute 'type' expected "CLOUD_ARMOR_EDGE", got "CLOUD_ARMOR"
--- FAIL: TestAccComputeSecurityPolicy_basicUpdate (41.37s)

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fixed permadiff on attempted `type` field updates in `google_computer_security_policy`, updating this field will now force recreation of the resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 50 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 50 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1060
Passed tests: 985
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFirewallPolicyAssociation_basic
• TestAccComputeSecurityPolicy_basicUpdate

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeFirewallPolicyAssociation_basic [Debug log]
TestAccComputeSecurityPolicy_basicUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[NickElliot]

LGTM!