Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Network Firewall Policy Association (global and region) resource from DCL to MMv1 #19976

Conversation

modular-magician
Copy link
Collaborator

Hello folks.
This PR is to move two Network Firewall Policy Association resources (global and region) from DCL to MMv1.

  • google_compute_network_firewall_policy_association
  • google_compute_region_network_firewall_policy_association

And this PR includes:

  • Creation of the resource on MMv1.
  • Creation of the examples and tests.
  • Remove references to DCL resource.

Note: This PR doesn't include the deletion of the DCL resource. This change will be done on the Delarative Resource Client Library repository.

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_network_firewall_policy_association` now uses MMv1 engine instead of DCL.
compute: `google_compute_region_network_firewall_policy_association` now uses MMv1 engine instead of DCL.

Derived from GoogleCloudPlatform/magic-modules#11366

…rce from DCL to MMv1 (hashicorp#11366)

Co-authored-by: Cameron Thornton <[email protected]>

[upstream:9a1402bf3fa39860cad1fb258010cbf01450e8d8]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 6271874 into hashicorp:main Oct 23, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-9a1402bf3fa39860cad1fb258010cbf01450e8d8 branch November 17, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant