Migrate Network Firewall Policy Association (global and region) resource from DCL to MMv1

[Samir-Cit]

Hello folks.
This PR is to move two Network Firewall Policy Association resources (global and region) from DCL to MMv1.

• google_compute_network_firewall_policy_association
• google_compute_region_network_firewall_policy_association

And this PR includes:

• Creation of the resource on MMv1.
• Creation of the examples and tests.
• Remove references to DCL resource.

Note: This PR doesn't include the deletion of the DCL resource. This change will be done on the Delarative Resource Client Library repository.

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_network_firewall_policy_association` now uses MMv1 engine instead of DCL.

compute: `google_compute_region_network_firewall_policy_association` now uses MMv1 engine instead of DCL.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 791 insertions(+), 466 deletions(-))
google-beta provider: Diff ( 10 files changed, 791 insertions(+), 466 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 158 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference
• Field region transitioned from optional+computed to optional google_compute_region_network_firewall_policy_association - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 979
Passed tests: 903
Skipped tests: 72
Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeNetworkFirewallPolicyAssociation_networkFirewallPolicyAssociationExample
• TestAccComputeNetworkFirewallPolicyRule_multipleRules
• TestAccComputeNetworkFirewallPolicyRule_securityProfileGroup_update
• TestAccComputeRegionNetworkFirewallPolicyAssociation_regionNetworkFirewallPolicyAssociationExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeNetworkFirewallPolicyAssociation_networkFirewallPolicyAssociationExample[Debug log]
TestAccComputeRegionNetworkFirewallPolicyAssociation_regionNetworkFirewallPolicyAssociationExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeNetworkFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_securityProfileGroup_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[github-actions]

@slevenick @trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 791 insertions(+), 466 deletions(-))
google-beta provider: Diff ( 10 files changed, 791 insertions(+), 466 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 158 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference
• Field region transitioned from optional+computed to optional google_compute_region_network_firewall_policy_association - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 982
Passed tests: 906
Skipped tests: 72
Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeDisk_storagePoolSpecified
• TestAccComputeInstance_bootDisk_storagePoolSpecified
• TestAccComputeNetworkFirewallPolicyRule_multipleRules
• TestAccComputeNetworkFirewallPolicyRule_securityProfileGroup_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_securityProfileGroup_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 534 insertions(+), 489 deletions(-))
google-beta provider: Diff ( 9 files changed, 534 insertions(+), 489 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 188 insertions(+))

[modular-magician]

Tests analytics

Total tests: 982
Passed tests: 904
Skipped tests: 72
Affected tests: 6

Click here to see the affected service packages

• compute

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeDisk_storagePoolSpecified
• TestAccComputeInstance_bootDisk_storagePoolSpecified
• TestAccComputeNetworkFirewallPolicyAssociation_networkFirewallPolicyAssociationExample
• TestAccComputeNetworkFirewallPolicyRule_multipleRules
• TestAccComputeNetworkFirewallPolicyRule_securityProfileGroup_update
• TestAccComputeRegionNetworkFirewallPolicyAssociation_regionNetworkFirewallPolicyAssociationExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeNetworkFirewallPolicyRule_multipleRules[Debug log]
TestAccComputeNetworkFirewallPolicyRule_securityProfileGroup_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyAssociation_networkFirewallPolicyAssociationExample[Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyAssociation_regionNetworkFirewallPolicyAssociationExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[github-actions]

@slevenick @c2thorn @trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @slevenick @c2thorn @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 817 insertions(+), 460 deletions(-))
google-beta provider: Diff ( 11 files changed, 817 insertions(+), 460 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 158 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1036
Passed tests: 960
Skipped tests: 73
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeNetworkFirewallPolicyRule_multipleRules
• TestAccComputeNetworkFirewallPolicyRule_securityProfileGroup_update
• TestAccComputeRegionNetworkFirewallPolicyRule_multipleRules

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyRule_multipleRules[Debug log]
TestAccComputeNetworkFirewallPolicyRule_securityProfileGroup_update[Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_multipleRules[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @slevenick @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 817 insertions(+), 460 deletions(-))
google-beta provider: Diff ( 11 files changed, 817 insertions(+), 460 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 158 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1039
Passed tests: 966
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log