Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deletion_delay_hours when importing during TestAccVmwareenginePrivateCloud_vmwareEnginePrivateCloudUpdate #18925

Conversation

modular-magician
Copy link
Collaborator

Addresses issues like this when testing import of the resource:

------- Stdout: -------
=== RUN   TestAccVmwareenginePrivateCloud_vmwareEnginePrivateCloudUpdate
=== PAUSE TestAccVmwareenginePrivateCloud_vmwareEnginePrivateCloudUpdate
=== CONT  TestAccVmwareenginePrivateCloud_vmwareEnginePrivateCloudUpdate
    vcr_utils.go:152: Step 2/4 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
          map[string]string{
        -   "deletion_delay_hours": "1",
          }
    testing_new.go:90: Error running post-test destroy, there may be dangling resources: exit status 1
        Error: Error waiting to delete PrivateCloud: got pending status "found"
--- FAIL: TestAccVmwareenginePrivateCloud_vmwareEnginePrivateCloudUpdate (17756.87s)
FAIL

This field is a virtual field (GoogleCloudPlatform/magic-modules#10764) so doesn't have a value immediately after import.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#11295

…nePrivateCloud_vmwareEnginePrivateCloudUpdate (hashicorp#11295)

[upstream:8a4ab31cd1269bc4a1ce35daea6a17d28c81b853]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit ced6e84 into hashicorp:main Jul 31, 2024
3 checks passed
Copy link

github-actions bot commented Sep 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2024
@modular-magician modular-magician deleted the downstream-pr-8a4ab31cd1269bc4a1ce35daea6a17d28c81b853 branch November 17, 2024 00:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant