-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore deletion_delay_hours
when importing during TestAccVmwareenginePrivateCloud_vmwareEnginePrivateCloudUpdate
#11295
Ignore deletion_delay_hours
when importing during TestAccVmwareenginePrivateCloud_vmwareEnginePrivateCloudUpdate
#11295
Conversation
deletion_delay_hours
when importingdeletion_delay_hours
when importing during TestAccVmwareenginePrivateCloud_vmwareEnginePrivateCloudUpdate
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 16 Click here to see the affected service packages
View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for adding this fix Sarah!
Could you please elaborate why a failed import fails the post delete check here and returns the Private Cloud in a 'found' state?
testing_new.go:90: Error running post-test destroy, there may be dangling resources: exit status 1
Error: Error waiting to delete PrivateCloud: got pending status "found"
@swamitagupta I think those are two separate problems with the test. First the test fails due to a failed assertion that the state of the imported resource should match its state from when it was being managed via the test framework (which this PR fixes), and then the test framework is reporting a failure because it's unable to delete the resources it provisioned. I believe "got pending status "found"" is an error surfaced from hashicorp/terraform-plugin-testing, and is due to how the the testing framework is waiting for a 404 after deletion but is still 'finding' the resource when performing GET requests. |
…nePrivateCloud_vmwareEnginePrivateCloudUpdate (GoogleCloudPlatform#11295)
…nePrivateCloud_vmwareEnginePrivateCloudUpdate (GoogleCloudPlatform#11295)
…nePrivateCloud_vmwareEnginePrivateCloudUpdate (GoogleCloudPlatform#11295)
…nePrivateCloud_vmwareEnginePrivateCloudUpdate (GoogleCloudPlatform#11295)
Addresses issues like this when testing import of the resource:
This field is a virtual field (#10764) so doesn't have a value immediately after import.
Release Note Template for Downstream PRs (will be copied)