Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deletion_protection wrapper for deleting instance #1211

Merged
merged 2 commits into from
Mar 16, 2018
Merged

Add deletion_protection wrapper for deleting instance #1211

merged 2 commits into from
Mar 16, 2018

Conversation

nickjacques
Copy link
Contributor

  • Throws a friendly error to the user immediately instead of waiting for the API to return a 400

Previously:

* google_compute_instance.instance_delprotect: Error deleting instance: googleapi: Error 400: Invalid resource usage: 'Resource cannot be deleted if it's protected against deletion.'., invalidResourceUsage

Now:

* google_compute_instance.instance_delprotect: Cannot delete instance instance-delprotect: instance Deletion Protection is enabled. Set deletion_protection to false for this resource and run "terraform apply" before attempting to delete it.

@ndmckinley this is a follow-on to #1205 to add friendly handling when you try to delete an instance with deletion_protection = true.

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Running the tests.

@nickjacques
Copy link
Contributor Author

Also updated the docs to call this out to users.

@nat-henderson
Copy link
Contributor

Tests pass! Merging.

@nat-henderson nat-henderson merged commit 8ada4ff into hashicorp:master Mar 16, 2018
ashish-amarnath pushed a commit to ashish-amarnath/terraform-provider-google that referenced this pull request Mar 20, 2018
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Oct 2, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants