Add deletion protection to resource_compute_instance

[nickjacques]

• Added deletion_protection boolean parameter for google_compute_instance resources (in resource_compute_instance.go).
  • Parameter is optional, default value is false
• Updated documentation to describe functionality
• Add unit tests to confirm functionality

This resolves #956.

[nickjacques]

Added unit tests:

• Added implicit false test to TestAccComputeInstance_basic1
• Created explicit false test with TestAccComputeInstance_deletionProtectionExplicitFalse
• Created explicit true test with TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse
  • This test creates a resource with explicit true, then updates it with explicit false, so we kill two birds with one stone (true and update). Update to false is required because otherwise the test harness can't delete the instance after tests complete.

@danawillow I think this is ready for review!

$ make testacc TEST=./google TESTARGS='-run=TestAccComputeInstance_basic1'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeInstance_basic1 -timeout 120m
=== RUN   TestAccComputeInstance_basic1
--- PASS: TestAccComputeInstance_basic1 (59.16s)
PASS
ok      github.com/terraform-providers/terraform-provider-google/google 59.188s

$ make testacc TEST=./google TESTARGS='-run=TestAccComputeInstance_deletionProtectionExplicitFalse'                                                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeInstance_deletionProtectionExplicitFalse -timeout 120m
=== RUN   TestAccComputeInstance_deletionProtectionExplicitFalse
--- PASS: TestAccComputeInstance_deletionProtectionExplicitFalse (179.77s)
PASS
ok      github.com/terraform-providers/terraform-provider-google/google 179.803s

$ make testacc TEST=./google TESTARGS='-run=TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse -timeout 120m
=== RUN   TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse
--- PASS: TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse (81.45s)
PASS
ok      github.com/terraform-providers/terraform-provider-google/google 81.485s

[nat-henderson]

Could you toss an ImportStateVerify test step here between step 0 and step 1? That way we can be sure that this works on import. I'm sure it does, it's just something we're trying to do lately.

[nickjacques]

Sure! Updating commit incoming.

[nat-henderson]

This looks great! Thanks for the contribution.

[nat-henderson]

Great! Running acceptance tests now.

[nat-henderson]

Tests pass, great. :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!