Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pub/Sub Lite reservation support to terraform. #10263

Conversation

modular-magician
Copy link
Collaborator

Also fix doc links for Pub/Sub Lite.

fixes #10257

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
`google_pubsub_lite_reservation`
pubsub:  Added support for references to `google_pubsub_lite_reservation` to `google_pubsub_lite_topic`.

Derived from GoogleCloudPlatform/magic-modules#5284

* Add Pub/Sub Lite reservation support to terraform.

Also fix doc links for Pub/Sub Lite.

* Add Pub/Sub Lite reservation support to terraform.

Also fix doc links for Pub/Sub Lite.

* Add Pub/Sub Lite reservation support to terraform.

Also fix doc links for Pub/Sub Lite.

* Add Pub/Sub Lite reservation support to terraform.

Also fix doc links for Pub/Sub Lite.

* Update to expander to use 'locations' instead of 'regions'.

Co-authored-by: Nathan Mckinley <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 2bd0903 into hashicorp:master Oct 6, 2021
@github-actions
Copy link

github-actions bot commented Nov 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2021
@modular-magician modular-magician deleted the downstream-pr-986eca72b2e3415b99073407d234d68d47dda1a4 branch November 17, 2024 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pub/Sub Lite Reservation Support
1 participant