Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pub/Sub Lite reservation support to terraform. #5284

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

dpcollins-google
Copy link
Contributor

@dpcollins-google dpcollins-google commented Oct 5, 2021

Also fix doc links for Pub/Sub Lite.

fixes hashicorp/terraform-provider-google#10257

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
`google_pubsub_lite_reservation`
pubsub:  Added support for references to `google_pubsub_lite_reservation` to `google_pubsub_lite_topic`.

Also fix doc links for Pub/Sub Lite.
@google-cla google-cla bot added the cla: yes label Oct 5, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@nat-henderson
Copy link
Contributor

A good start - it looks like you've referenced some examples but haven't added them to the PR. You'll need those to show that the code is working. :)

Also fix doc links for Pub/Sub Lite.
@dpcollins-google
Copy link
Contributor Author

I've added the examples- building now, unfortunately it takes a while.

@nat-henderson
Copy link
Contributor

Yep! LGTM if the tests pass - I'll send the command to run them once the differ finished.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 755 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 11 files changed, 756 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 2 files changed, 96 insertions(+))
TF OiCS: Diff ( 5 files changed, 119 insertions(+))

@nat-henderson
Copy link
Contributor

Okay - running the tests now. /gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 755 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 10 files changed, 755 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 2 files changed, 96 insertions(+))
TF OiCS: Diff ( 5 files changed, 119 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample|TestAccPubsubLiteTopic_pubsubLiteTopicBasicExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209185

@nat-henderson
Copy link
Contributor

Great - as long as that last test passes, this can go in today and be released next week Monday.

@nat-henderson
Copy link
Contributor

Ah, unfortunately not:

------- Stdout: -------
=== RUN   TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample
=== PAUSE TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample
=== CONT  TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample
provider_test.go:278: Step 1/2 error: After applying this test step, the plan was not empty.
stdout:
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# google_pubsub_lite_reservation.example will be updated in-place
~ resource "google_pubsub_lite_reservation" "example" {
id                  = "projects/1067888929963/locations/us-central1/reservations/tf-test-example-reservationmbdz2vv2gl"
name                = "tf-test-example-reservationmbdz2vv2gl"
~ throughput_capacity = 0 -> 2
# (1 unchanged attribute hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample (7.51s)
FAIL

Also fix doc links for Pub/Sub Lite.
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 755 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 10 files changed, 755 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 2 files changed, 96 insertions(+))
TF OiCS: Diff ( 5 files changed, 119 insertions(+))

Also fix doc links for Pub/Sub Lite.
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 755 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 10 files changed, 755 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 2 files changed, 96 insertions(+))
TF OiCS: Diff ( 5 files changed, 119 insertions(+))

@nat-henderson
Copy link
Contributor

It just needed a minor change - it needed to use locations instead of regions for the reference. :)

Tests pass on my machine but I'll wait for the diffs to generate to be sure.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 756 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 11 files changed, 757 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 2 files changed, 97 insertions(+))
TF OiCS: Diff ( 5 files changed, 119 insertions(+))

@nat-henderson nat-henderson merged commit 986eca7 into GoogleCloudPlatform:master Oct 6, 2021
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
…rm#5284)

* Add Pub/Sub Lite reservation support to terraform.

Also fix doc links for Pub/Sub Lite.

* Add Pub/Sub Lite reservation support to terraform.

Also fix doc links for Pub/Sub Lite.

* Add Pub/Sub Lite reservation support to terraform.

Also fix doc links for Pub/Sub Lite.

* Add Pub/Sub Lite reservation support to terraform.

Also fix doc links for Pub/Sub Lite.

* Update to expander to use 'locations' instead of 'regions'.

Co-authored-by: Nathan Mckinley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pub/Sub Lite Reservation Support
3 participants