-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pub/Sub Lite reservation support to terraform. #5284
Add Pub/Sub Lite reservation support to terraform. #5284
Conversation
Also fix doc links for Pub/Sub Lite.
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ndmckinley, please review this PR or find an appropriate assignee. |
A good start - it looks like you've referenced some examples but haven't added them to the PR. You'll need those to show that the code is working. :) |
Also fix doc links for Pub/Sub Lite.
I've added the examples- building now, unfortunately it takes a while. |
Yep! LGTM if the tests pass - I'll send the command to run them once the differ finished. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 10 files changed, 755 insertions(+), 6 deletions(-)) |
Okay - running the tests now. /gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 10 files changed, 755 insertions(+), 6 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample|TestAccPubsubLiteTopic_pubsubLiteTopicBasicExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209185 |
Great - as long as that last test passes, this can go in today and be released next week Monday. |
Ah, unfortunately not:
|
Also fix doc links for Pub/Sub Lite.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 10 files changed, 755 insertions(+), 6 deletions(-)) |
Also fix doc links for Pub/Sub Lite.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 10 files changed, 755 insertions(+), 6 deletions(-)) |
It just needed a minor change - it needed to use Tests pass on my machine but I'll wait for the diffs to generate to be sure. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 10 files changed, 756 insertions(+), 6 deletions(-)) |
…rm#5284) * Add Pub/Sub Lite reservation support to terraform. Also fix doc links for Pub/Sub Lite. * Add Pub/Sub Lite reservation support to terraform. Also fix doc links for Pub/Sub Lite. * Add Pub/Sub Lite reservation support to terraform. Also fix doc links for Pub/Sub Lite. * Add Pub/Sub Lite reservation support to terraform. Also fix doc links for Pub/Sub Lite. * Update to expander to use 'locations' instead of 'regions'. Co-authored-by: Nathan Mckinley <[email protected]>
Also fix doc links for Pub/Sub Lite.
fixes hashicorp/terraform-provider-google#10257
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.