Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to specify api/ files, pull directly from the DCL #10199

Conversation

modular-magician
Copy link
Collaborator

Fixes #8201

This PR removes the need to specify api/ files for resources (although not samples quite yet) and pulls them directly off of the DCL's exported YAMLs. This means we'll stay up-to-date for better or for worse, although generally for the better. There's some pain in the upgrade- our YAMLs had drifted, and there were some dangerous-to-apply updates last I checked.

Changes are contained to main.go, and all other changes in the PR are non-functional (removing api files, removing old overrides)

Marked as WIP because of the drift- we need to resolve those to compatible before we can merge this. Outstanding issues:

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

gke_hub: made the `config_membership` field in `google_gke_hub_feature` required, disallowing invalid configurations
gke_hub: made the `configmanagement`, `feature`, `location`, `membership` fields in `google_gke_hub_feature_membership` required, disallowing invalid configurations
eventarc: added support for `uid` output field, `cloud_function` destination to `google_eventarc_trigger`
gke_hub: added support for `resource_state`, `state` outputs to `google_gke_hub_feature`
gke_hub: added support for `gcp_service_account_email` when configuring Git sync in `google_gke_hub_feature_membership`

Derived from GoogleCloudPlatform/magic-modules#5197

@modular-magician modular-magician merged commit 8227284 into hashicorp:master Sep 30, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2021
@modular-magician modular-magician deleted the downstream-pr-7059c1b5b974efb63144079e708e0b07035f2c7c branch November 17, 2024 00:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opt-in resources to tpgtools generation using override files
1 participant