-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dataproc WorkflowTemplate, rename REQUIRED_OVERRIDE #5249
Update Dataproc WorkflowTemplate, rename REQUIRED_OVERRIDE #5249
Conversation
1beb07b
to
a803754
Compare
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataprocWorkflowTemplate_basic|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginAdvancedExample|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=207918 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great rename! Looks reasonable assuming the dataproc test passes
Changes the name of REQUIRED_OVERRIDE to CUSTOM_SCHEMA_VALUES as that makes a little more sense (it applies to more than required) and removes the
ForceNew
value since it wasn't hooked up anywhere.This updates the Dataproc WorkflowTemplate resource, fixing the
version
field retyping that was otherwise blocking #5197. I deprecated it- not sure if it's on the docket for4.0.0
, I haven't rolled it in yet (we already have enough to do)If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)