Add SLO "availability" SLI metric support

[Tailzip]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Through the console or API, we can configure a SLO based on availability metric, but support is missing in basic_sli config block on the google_monitoring_slo resource.

New or Affected Resource(s)

• google_monitoring_slo

Potential Terraform Configuration

data "google_monitoring_app_engine_service" "default" {
  module_id = "default"
}

resource "google_monitoring_slo" "appeng_slo" {
  service = data.google_monitoring_app_engine_service.default.service_id

  slo_id = "ae-slo"
  display_name = "Terraform Test SLO for App Engine"

  goal = 0.9
  calendar_period = "DAY"

  basic_sli {
    availability {}
  }
}

References

• https://cloud.google.com/stackdriver/docs/solutions/slo-monitoring/ui/create-slo#sli-metric
• https://cloud.google.com/monitoring/api/ref_v3/rest/v3/services.serviceLevelObjectives#basicsli
• https://cloud.google.com/monitoring/api/ref_v3/rest/v3/services.serviceLevelObjectives#availabilitycriteria
• b/173480266

[venkykuberan]

@Tailzip per API doc, availability SLI isn't supported yet. Looks to me its just a place holder. I am not sure we can achieve any by passing empty availability{} to API. Can you please brief us what you are trying to achieve with the availability metric there ?

[rileykarson]

@venkykuberan: Is it possible that specifying availability in a request enables the feature and that placeholder is for more configuration options? The original request indicates the feature can be added through the Cloud Console.

[rileykarson]

Also, note that the BasicSli object appears at multiple points during the request object. We'll want to support them all to close this issue. See the sample in #7884, for example.

[Tailzip]

Agreed with @rileykarson, it looks like it's a placeholder according to the API doc. It is indeed already possible to enable that feature directly in the Console, or via API as mentioned in the issue description.

[rileykarson]

Looks like we missed this in at least one place (per #7884), we'll want to add it in all applicable locations. Sorry, I should have caught this in review! @venkykuberan are you able to pick this up this sprint?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!