Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

availability sli for SLO monitoring resource #2908

Merged
merged 1 commit into from
Jan 27, 2021
Merged

availability sli for SLO monitoring resource #2908

merged 1 commit into from
Jan 27, 2021

Conversation

modular-magician
Copy link
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

monitoring : added `availability` sli metric support for the resource `google_monitoring_slo`

fixes hashicorp/terraform-provider-google#7239

Derived from GoogleCloudPlatform/magic-modules#4344

@modular-magician
availability sli for SLO monitoring resource (hashicorp#4344)
ce4cd40 
* inital check-in for review

* custom_flattner added

* extra line added at EOF

* PR comments implemented

* custom_expander logic is placed in encoder as it more appropriate, validation func added

* empty lines added at EOF

* PR comments implemented, Test cases added

* fixed encoder for the case where basicsli is not used in the config

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/m label Jan 27, 2021
@modular-magician modular-magician merged commit a28e1c4 into hashicorp:master Jan 27, 2021
@modular-magician modular-magician deleted the downstream-pr-b01da15ce7104410bfbfbaa902461a966f1f21da branch November 16, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SLO "availability" SLI metric support
1 participant
@modular-magician