Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"google_monitoring_slo" is missing Availability option #7884

Closed
marcfong opened this issue Nov 25, 2020 · 3 comments
Closed

"google_monitoring_slo" is missing Availability option #7884

marcfong opened this issue Nov 25, 2020 · 3 comments

Comments

@marcfong
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.12.24

  • provider.google v3.49.0
  • provider.random v3.0.0

Affected Resource(s)

  • google_monitoring_slo

Terraform Configuration Files

resource "google_monitoring_slo" "windows_based" {
  service = "ist:xxxxxxxxx"
  display_name = "Terraform Test SLO with window based SLI"

  goal = 0.7
  calendar_period = "FORTNIGHT"

  windows_based_sli {
    window_period = "60s"
    good_total_ratio_threshold {
      threshold = 0.7
      basic_sli_performance {
        availability {
        }
      }
    }
  }
}

Debug Output

Error: Unsupported block type
  on main.tf line 14, in resource "google_monitoring_slo" "windows_based":
  14:           availability {
Blocks of type "availability" are not expected here.

Panic Output

Expected Behavior

Terraform plan should succeed.
The CLoud Monitoring API supports both "Availability" and "latency" parameters to the "BlasicSliPerformance" type.
See API docs here :
https://cloud.google.com/monitoring/api/ref_v3/rest/v3/services.serviceLevelObjectives#BasicSli

Actual Behavior

Terraform apply failed.

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
@ghost ghost added bug labels Nov 25, 2020
@edwardmedia edwardmedia self-assigned this Nov 25, 2020
@edwardmedia
Copy link
Contributor

@rileykarson
Copy link
Collaborator

Closing in favour of #7239

@ghost
Copy link

ghost commented Jan 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants