Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_artifact_registry_repository after import reported as needing to be recreated #6936

Closed
Assignees
Labels

Comments

@charleskorn
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.12.29
+ provider.google v3.32.0
+ provider.google-beta v3.32.0

Affected Resource(s)

  • google_artifact_registry_repository

Terraform Configuration Files

resource "google_artifact_registry_repository" "images" {
  provider = google-beta

  location      = "us-central1"
  repository_id = "images"
  format        = "DOCKER"
}

Expected Behavior

After importing an existing repository, the plan does not need to change the repository.

Actual Behavior

After importing an existing repository, the plan reports that it needs to recreate the repository:

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # google_artifact_registry_repository.images must be replaced
-/+ resource "google_artifact_registry_repository" "images" {
      ~ create_time   = "2020-08-05T00:31:35.850840Z" -> (known after apply)
        format        = "DOCKER"
      ~ id            = "projects/my-project/locations/us-central1/repositories/" -> (known after apply)
      - labels        = {} -> null
        location      = "us-central1"
      ~ name          = "images" -> (known after apply)
      ~ project       = "my-project" -> (known after apply)
      + repository_id = "images" # forces replacement
      ~ update_time   = "2020-08-05T00:31:35.850840Z" -> (known after apply)

      - timeouts {}
    }

Looking at the state file after importing the repository, it looks as though the repository_id is not being persisted to the state file:

  "resources": [
    {
      "instances": [
        {
          "schema_version": 0,
          "attributes": {
            "create_time": "2020-08-05T00:31:35.850840Z",
            "description": "",
            "format": "DOCKER",
            "id": "projects/my-project/locations/us-central1/repositories/",
            "kms_key_name": "",
            "labels": {},
            "location": "us-central1",
            "name": "images",
            "project": "my-project",
            "repository_id": null,
            "timeouts": {
              "create": null,
              "delete": null,
              "update": null
            },
            "update_time": "2020-08-05T00:31:35.850840Z"
          },
          "private": "..."
        }
      ]
    }
  ]

Steps to Reproduce

  1. terraform apply to create repository
  2. Remove state file
  3. terraform import google_artifact_registry_repository.images "projects/my-project/locations/us-central1/repositories/images"
  4. terraform plan
@ghost
Copy link

ghost commented Sep 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.