Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buggy import of artifact repository. #3838

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

nat-henderson
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#6936.

The issue here is that in this resource, name is an output, repository_id is what we'd normally call name.

Release Note Template for Downstream PRs (will be copied)

artifactrepository: Fix import failure of `google_artifact_registry_repository`.

@google-cla google-cla bot added the cla: yes label Aug 6, 2020
@nat-henderson nat-henderson requested a review from slevenick August 6, 2020 19:05
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138119"

@nat-henderson
Copy link
Contributor Author

Since tests are down right now I'm just going to run the tests locally.

@nat-henderson
Copy link
Contributor Author

Confirmed by reading the logs of TestAccArtifactRegistryRepository_artifactRegistryRepositoryBasicExample that the import works and does not require a recreate.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstance_shieldedVmConfig1|TestAccComputeInstance_shieldedVmConfig2|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_basic|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withInvalidReleaseChannel|TestAccContainerCluster_misc|TestAccContainerCluster_withMasterAuthConfig|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withAddons|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_regional|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_network|TestAccContainerCluster_backend|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolConflictingNameFields|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerNodePool_basic|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_nodeLocations|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_resize|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_shieldedInstanceConfig|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccMonitoringMetricDescriptor_update|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basic_with_user_labels You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138123"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_artifact_registry_repository after import reported as needing to be recreated
3 participants