Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reassigning to a specific reviewer doesn't work as expected #20649

Closed
melinath opened this issue Dec 10, 2024 · 0 comments · Fixed by GoogleCloudPlatform/magic-modules#12767, hashicorp/terraform-provider-google-beta#9071, #20930 or GoogleCloudPlatform/terraform-google-conversion#3312
Closed

Reassigning to a specific reviewer doesn't work as expected #20649

melinath opened this issue Dec 10, 2024 · 0 comments · Fixed by GoogleCloudPlatform/magic-modules#12767, hashicorp/terraform-provider-google-beta#9071, #20930 or GoogleCloudPlatform/terraform-google-conversion#3312
Labels
magician-pr-ux size/s technical-debt
Milestone
Near-Term Goals

Comments

@melinath
Copy link
Collaborator

What kind of contribution is this issue about?

Pull request UX

Details

GoogleCloudPlatform/magic-modules#12530 (comment) - the comment should've reassigned to a specific reviewer but instead chose a random reviewer.

References

No response
@melinath melinath added this to the Near-Term Goals milestone Dec 16, 2024
@shuyama1 shuyama1 removed their assignment Dec 16, 2024
@melinath melinath mentioned this issue Jan 15, 2025
Closed
melinath added a commit to melinath/magic-modules that referenced this issue Jan 15, 2025
@melinath
Made reassign-reviewer correctly pass argument to the underlying command
1f85959 
Fixed hashicorp/terraform-provider-google#20649
@melinath melinath mentioned this issue Jan 15, 2025
Merged
This was referenced Jan 15, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
magician-pr-ux size/s technical-debt
Projects
None yet
Milestone
Near-Term Goals
2 participants
@melinath @shuyama1