Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TF: unskip test TestAccDataprocVirtualCluster_basic #12530

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

devanshikhatsuriya
Copy link
Contributor

@devanshikhatsuriya devanshikhatsuriya commented Dec 10, 2024

2024-12-10T03:43:14.318Z [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccDataprocVirtualCluster_basic
--- PASS: TestAccDataprocVirtualCluster_basic (694.18s)
dataproc: unskip failing test fixed in https://github.com/GoogleCloudPlatform/magic-modules/pull/12454.

@github-actions github-actions bot requested a review from BBBmau December 10, 2024 03:39
Copy link

github-actions bot commented Dec 10, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath , a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 10, 2024
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 10, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the changes in this PR were already in #12454 - except removing SkipIfVcr (which is actually missing here - possibly not pushed?)

@melinath melinath removed the request for review from BBBmau December 10, 2024 18:13
@melinath
Copy link
Member

@modular-magician reassign-reviewer melinath

@github-actions github-actions bot requested a review from SirGitsalot December 10, 2024 18:14
@melinath melinath removed the request for review from SirGitsalot December 10, 2024 18:16
@github-actions github-actions bot requested a review from melinath December 10, 2024 18:32
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Dec 10, 2024
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/dataproc labels Dec 10, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 deletions(-))

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 10, 2024
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 60
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • dataproc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocVirtualCluster_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 60
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • dataproc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocVirtualCluster_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocVirtualCluster_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocVirtualCluster_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants