Add conflicts with, node_version only works on the default node pool (#…

…4762) (#9100) * Add conflicts with, node_version only works on the default node pool * Use customizediff rather than conflicts with Signed-off-by: Modular Magician <[email protected]>
hashicorp · May 6, 2021 · 950ae7e · 950ae7e
1 parent 8736b31
commit 950ae7e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/.changelog/4762.txt b/.changelog/4762.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+container: added validation to check that both `node_version` and `remove_default_node_pool` cannot be set on `google_container_cluster`
+```
diff --git a/google/resource_container_cluster.go b/google/resource_container_cluster.go
@@ -105,6 +105,7 @@ func resourceContainerCluster() *schema.Resource {
 			resourceNodeConfigEmptyGuestAccelerator,
 			containerClusterPrivateClusterConfigCustomDiff,
 			containerClusterAutopilotCustomizeDiff,
+			containerClusterNodeVersionRemoveDefaultCustomizeDiff,
 		),
 
 		Timeouts: &schema.ResourceTimeout{
@@ -3439,3 +3440,11 @@ func containerClusterAutopilotCustomizeDiff(_ context.Context, d *schema.Resourc
 	}
 	return nil
 }
+
+// node_version only applies to the default node pool, so it should conflict with remove_default_node_pool = true
+func containerClusterNodeVersionRemoveDefaultCustomizeDiff(_ context.Context, d *schema.ResourceDiff, meta interface{}) error {
+	if d.Get("node_version").(string) != "" && d.Get("remove_default_node_pool").(bool) {
+		return fmt.Errorf("node_version can only be specified if remove_default_node_pool is not true")
+	}
+	return nil
+}