Skip to content

Commit

Permalink
dns: ignore case changes for DS records (#4769) (#9099)
Browse files Browse the repository at this point in the history
DS records need case change suppression as with "MX" records.

Closes #9093

Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored May 6, 2021
1 parent ab1a16c commit 8736b31
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .changelog/4769.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
dns: suppress spurious diffs due to case changes in DS records
```
2 changes: 1 addition & 1 deletion google/resource_dns_resource_dns_record_set.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func rrdatasDnsDiffSuppress(k, old, new string, d *schema.ResourceData) bool {
case "AAAA":
// parse ipv6 to a key from one list
return net.ParseIP(record).String()
case "MX":
case "MX", "DS":
return strings.ToLower(record)
case "TXT":
return strings.ToLower(strings.Trim(record, `"`))
Expand Down

0 comments on commit 8736b31

Please sign in to comment.