Skip to content

Commit

Permalink
report bucket name when not empty while deleting (#3501) (#6355)
Browse files Browse the repository at this point in the history
Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored May 12, 2020
1 parent 0c6a726 commit 4b47d26
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .changelog/3501.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
storage: added `google_storage_bucket` bucket name to the error message when the bucket can't be deleted because it's not empty
```
2 changes: 1 addition & 1 deletion google/resource_storage_bucket.go
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ func resourceStorageBucketDelete(d *schema.ResourceData, meta interface{}) error
}

if !d.Get("force_destroy").(bool) {
deleteErr := errors.New("Error trying to delete a bucket containing objects without `force_destroy` set to true")
deleteErr := fmt.Errorf("Error trying to delete bucket %s containing objects without `force_destroy` set to true", bucket)
log.Printf("Error! %s : %s\n\n", bucket, deleteErr)
return deleteErr
}
Expand Down

0 comments on commit 4b47d26

Please sign in to comment.