Added support for request-based SLIs in monitoring SLO (#3491) (#6353)

* initial slo resource * whitespace and update mask * add exactly X of to slo descriptions * unit tests Signed-off-by: Modular Magician <[email protected]>
hashicorp · May 12, 2020 · 0c6a726 · 0c6a726
1 parent 93047df
commit 0c6a726
Show file tree

Hide file tree

Showing 7 changed files with 760 additions and 15 deletions.
diff --git a/.changelog/3491.txt b/.changelog/3491.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+monitoring: Added `request_based` SLI support to `google_monitoring_slo` 
+```
diff --git a/google/resource_app_engine_domain_mapping.go b/google/resource_app_engine_domain_mapping.go
@@ -293,7 +293,8 @@ func resourceAppEngineDomainMappingUpdate(d *schema.ResourceData, meta interface
 	updateMask := []string{}
 
 	if d.HasChange("ssl_settings") {
-		updateMask = append(updateMask, "ssl_settings.certificate_id,ssl_settings.ssl_management_type")
+		updateMask = append(updateMask, "ssl_settings.certificate_id",
+			"ssl_settings.ssl_management_type")
 	}
 	// updateMask is a URL parameter but not present in the schema, so replaceVars
 	// won't set it

diff --git a/google/resource_kms_crypto_key.go b/google/resource_kms_crypto_key.go
@@ -272,7 +272,8 @@ func resourceKMSCryptoKeyUpdate(d *schema.ResourceData, meta interface{}) error
 	}
 
 	if d.HasChange("rotation_period") {
-		updateMask = append(updateMask, "rotationPeriod,nextRotationTime")
+		updateMask = append(updateMask, "rotationPeriod",
+			"nextRotationTime")
 	}
 
 	if d.HasChange("version_template") {